Fix errors in setGState in PartialEvaluator_getTextContent that prevents text-selection from working properly
#7374
Conversation
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0b8846f7093204f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6c53b0cc93ba04d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0b8846f7093204f/output.txt Total script time: 21.17 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6c53b0cc93ba04d/output.txt Total script time: 27.76 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/47f24e3f2ba0b27/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/47f24e3f2ba0b27/output.txt Total script time: 1.07 mins Published |
|
I can confirm that this fixes the issue for @yurydelendik Could you review this one? |
…revents text-selection from working properly Currently `setGState` is completely broken, and looking through the history of that code, it seems to me that this may never have worked correctly. This patch fixes the text-selection in `extgstate.pdf` in the test-suite, which is also added as a `text` test.
|
Now with one less stupid typo in the modified /botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b425e655d81df08/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6d3d5f3a5f41ce8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.22.172.223:8877/9370d17d2578f4b/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 1 Live output at: http://107.21.233.14:8877/9a3405481770f98/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b425e655d81df08/output.txt Total script time: 21.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6d3d5f3a5f41ce8/output.txt Total script time: 27.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9370d17d2578f4b/output.txt Total script time: 21.06 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9a3405481770f98/output.txt Total script time: 27.57 mins
|
|
Looks good. Thank you for the patch. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5e628c4167c1ff2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ffbbc0a29037fb3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ffbbc0a29037fb3/output.txt Total script time: 21.32 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5e628c4167c1ff2/output.txt Total script time: 26.76 mins
|
Currently
setGStateis completely broken, and looking through the history of that code, it seems to me that this may never have worked correctly.This patch fixes the text-selection in
extgstate.pdfin the test-suite, which is also added as atexttest.