Attempt to ignore multiple identical Tf (setFont) commands in PartialEvaluator_getTextContent (issue 5808)
#7387
Conversation
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7df65102aa1c333/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7df65102aa1c333/output.txt Total script time: 1.06 mins Published |
|
Looks really good to me. I also wouldn't call it fixed entirely, but it's a large step in the right direction. I think this will benefit other Scribus-generated PDF files too that we do not know of. |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/58a616c15cfd60f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bd6618735d5bc20/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/58a616c15cfd60f/output.txt Total script time: 21.15 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bd6618735d5bc20/output.txt Total script time: 27.68 mins
|
…lEvaluator_getTextContent` (issue 5808) This patch improves the performance of issue 5808, but I'm not sure if it's enough to call it fixed. On average, this patch reduces the number of textLayer div's by a factor of 3, and it also reduces the time spend in `getTextContent` by a factor of ~2. The PDF file is generated by `Scribus PDF`, which for reasons I cannot understand is placing redundant `Tf` commands before *every* showText command. Note how the PDF file also contains lots of (basically) identical fonts, but with slightly different names, which causes unnecessary font-switching. This causes some unnecessary breaking of textLayer div's, but this issue cannot be easily worked around.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/53d1ce9ac6378ba/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8a729af834d872e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/8a729af834d872e/output.txt Total script time: 23.07 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/53d1ce9ac6378ba/output.txt Total script time: 28.64 mins
|
|
r+ |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/0151ecc1ea14a1f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/31194223efbc016/output.txt |
|
Thank you for the patch |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/0151ecc1ea14a1f/output.txt Total script time: 23.30 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/31194223efbc016/output.txt Total script time: 27.75 mins
|
This patch improves the performance of issue #5808, but I'm not sure if it's enough to call it fixed. On average, this patch reduces the number of textLayer div's by a factor of 3, and it also reduces the time spend in
getTextContentby a factor of ~2.The PDF file is generated by
Scribus PDF, which for reasons I cannot understand is placing redundantTfcommands before every showText command.Note how the PDF file also contains lots of (basically) identical fonts, but with slightly different names, which causes unnecessary font-switching. This causes some unnecessary breaking of textLayer div's, but this issue cannot be easily worked around.
/cc @timvandermeij