[Firefox addon] Change the minimum supported version to Firefox 38 and remove a bunch old no longer necessary fallback code

[Snuffleupagus]

From the discussion in issue #7386, it wasn't really clear if we can restrict addon support to Firefox 45 (i.e. the version that corresponds to the current ESR version).

However, we have a bunch of code for very old Firefox versions. Hence this patch changes the minimum supported version to Firefox 38 (which was released on 2015-05-12, and correspond to the previous ESR version), and removes code that only applies to old Firefox versions.

Regardless what we end up deciding regarding addon support for previous Firefox versions, given the amount of code that even the Firefox >= 38 condition lets us remove, I certainly think that there is value in doing this.

---

This change is

[Snuffleupagus]

/botio-linux preview

[pdfjsbot]

From: Bot.io (Linux)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9324528f42b27f6/output.txt

[pdfjsbot]

From: Bot.io (Linux)

---

Success

Full output at http://107.21.233.14:8877/9324528f42b27f6/output.txt

Total script time: 1.09 mins

Published

• Viewer: http://107.21.233.14:8877/9324528f42b27f6/web/viewer.html
• B2G Viewer: http://107.21.233.14:8877/9324528f42b27f6/extensions/b2g/content/web/viewer.html
• Extension: http://107.21.233.14:8877/9324528f42b27f6/extensions/firefox/pdf.js.xpi

[timvandermeij]

I totally agree that we should do this.

[yurydelendik]

Looks good with comment with the 'getCodebasePrincipal' issue addressed.

---

Reviewed 4 of 4 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

extensions/firefox/content/PdfStreamConverter.jsm, line 1045 [r1] (raw file):

        ssm.createCodebasePrincipal(uri, aRequest.loadInfo.originAttributes);
    } else {
      resourcePrincipal = ssm.getNoAppCodebasePrincipal(uri);

Use 'getCodebasePrincipal' instead here (and comment above), see https://bugzilla.mozilla.org/show_bug.cgi?id=806587

---

Comments from Reviewable

[Snuffleupagus]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

extensions/firefox/content/PdfStreamConverter.jsm, line 1045 [r1] (raw file):

Previously, yurydelendik (Yury Delendik) wrote…

Use 'getCodebasePrincipal' instead here (and comment above), see https://bugzilla.mozilla.org/show_bug.cgi?id=806587

Done, thanks for the review!

---

Comments from Reviewable

[yurydelendik]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/19c76ba575d6945/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://107.22.172.223:8877/19c76ba575d6945/output.txt

Total script time: 1.79 mins

Published

• Viewer: http://107.22.172.223:8877/19c76ba575d6945/web/viewer.html
• B2G Viewer: http://107.22.172.223:8877/19c76ba575d6945/extensions/b2g/content/web/viewer.html
• Extension: http://107.22.172.223:8877/19c76ba575d6945/extensions/firefox/pdf.js.xpi

[yurydelendik]

Thank you for the patch.