Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip mapping of glyphs to Unicode "Ideographic space" (issue 7416) #7427

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Skip mapping of glyphs to Unicode "Ideographic space" (issue 7416) #7427

merged 1 commit into from
Jun 24, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

Fixes #7416, which is an IE specific issue.

@brendandahl I think this should do it. Since I cannot reproduce the issue in neither Firefox nor Chrome, but only in IE, I'm not sure how meaningful it would be to add a test-case.
But please let me know if you think that we need one anyway!

@brendandahl
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @brendandahl received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f92ec0b01764b9b/output.txt

@timvandermeij
Copy link
Contributor

This patch indeed seems to fix the issue, as reported by two users in the issue above. Nice work!

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.22.172.223:8877/ae38ae7a2df7d4a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/28fc974582ac080/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ae38ae7a2df7d4a/output.txt

Total script time: 22.48 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/28fc974582ac080/output.txt

Total script time: 28.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik yurydelendik merged commit 671f33a into mozilla:master Jun 24, 2016
@yurydelendik
Copy link
Contributor

Thank you for the patch.

@Snuffleupagus Snuffleupagus deleted the fonts-skip-mapping-ideographic-space branch June 24, 2016 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants