Move Chromium URL rewrite to top of viewer.js #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Chromium-specific URL rewriting code to the top of viewer.js (before the PDF.js library) to make sure that the URL is as expected. This ensures that variables that synchronously depends on the URL (e.g. PDFViewerApplication.initialBookmark) are properly set.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Chromium-specific URL rewriting code to the top of viewer.js (before the PDF.js library) to make sure that the URL is as expected.
This ensures that variables that synchronously depends on the URL (e.g.
PDFViewerApplication.initialBookmark) are properly set.Test:
This is currently broken, which I learned through a feature request from the Chrome Web Store (asking for
#search=to work, while I was pretty sure that it should work).