[api-minor] Add a parameter to PDFPageProxy_getTextContent that controls whether PartialEvaluator_getTextContent will attempt to combine same line text items
#7475
Conversation
| @@ -1,4 +1,4 @@ | |||
| /* Copyright 2012 Mozilla Foundation | |||
| /* Copyright 2012 Mozilla Foundation | |||
There was a problem hiding this comment.
Nit: this change does not seem necessary
There was a problem hiding this comment.
Thanks, it certainly shouldn't be there, good catch! I've got no idea how that happened :-)
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c180c800583d55f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bea2839edf90775/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c180c800583d55f/output.txt Total script time: 22.80 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bea2839edf90775/output.txt Total script time: 27.85 mins
|
|
r+ with making combineTextItems true by default at the API level (perhaps making it disableCombineTextItems and use combineTextItems at the core) |
…trols whether `PartialEvaluator_getTextContent` will attempt to combine same line text items From the discussion in issue 7445, it seems that there may be cases where an API consumer would want to get the text content as is, without combined text items.
|
@yurydelendik Thanks for the review! Is the updated patch more what you had in mind? /botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4d8395f8d373324/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/36c9d6b4a00458b/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/36c9d6b4a00458b/output.txt Total script time: 22.67 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4d8395f8d373324/output.txt Total script time: 27.55 mins
|
|
Thank you for the patch. |
From the discussion in issue #7445, it seems that there may be cases where an API consumer would want to get the text content as is, without combined text items.