Ensure that we don't reset the current page view if the user inputs an invalid page number (PR 7289 follow-up) #7485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n invalid page number (PR 7289 follow-up) After PR 7289, we'll now reset the current page view in cases where I don't think we should. To avoid this, this patch ensures that we'll not modify the position when the page number is out-of-bounds. **STR:** 1. Open http://mozilla.github.io/pdf.js/web/viewer.html#page=1&zoom=auto,-98,696 2. Enter an invalid number, e.g. `1000`, in the `pageNumber` input. **ER:** The current position in the document shouldn't change, since the page number wasn't valid. **AR:** The document resets to the top of the page `1`.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/9de18f57bcddff3/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/9de18f57bcddff3/output.txt Total script time: 1.86 mins Published |
|
Good fix, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #7289, we'll now reset the current page view in cases where I don't think we should. To avoid this, this patch ensures that we'll not modify the position when the page number is out-of-bounds.
STR:
1000, in thepageNumberinput.ER:
The current position in the document shouldn't change, since the page number wasn't valid.
AR:
The document resets to the top of page
1.