Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit-tests for asynchronous methods in primitives.js #7555

Merged
merged 1 commit into from
Aug 22, 2016
Merged

Add unit-tests for asynchronous methods in primitives.js #7555

merged 1 commit into from
Aug 22, 2016

Conversation

Snuffleupagus
Copy link
Collaborator

In PR #7520, I missed the fact that we currently have no unit-tests for Dict_getAsync.

In PR 7520, I missed the fact that we currently have no unit-tests for `Dict_getAsync`.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/93506b877ff857e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/ba1d9668ad8d832/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/ba1d9668ad8d832/output.txt

Total script time: 1.74 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/93506b877ff857e/output.txt

Total script time: 2.04 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 200c857 into mozilla:master Aug 22, 2016
@timvandermeij
Copy link
Contributor

Thank you!

@Snuffleupagus Snuffleupagus deleted the primitives-async-unit-tests branch August 22, 2016 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants