Change src/core/jpg.js to use the error utility function instead of throwing
#7591
Conversation
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b70804968c25b57/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/8998885e69eedf0/output.txt |
|
Please note: I pushed a new version of the patch that only removed a superfluous newline at the top of the file. Obviously I didn't see this until I had already triggered testing :-( |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/8998885e69eedf0/output.txt Total script time: 24.04 mins
Image differences available at: http://107.22.172.223:8877/8998885e69eedf0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/b70804968c25b57/output.txt Total script time: 29.24 mins
Image differences available at: http://107.21.233.14:8877/b70804968c25b57/reftest-analyzer.html#web=eq.log |
| jpegImage.decodeTransform = transform; | ||
| var jpegImage = new JpegImage(); | ||
|
|
||
| // Checking if values needs to be transformed before conversion. |
There was a problem hiding this comment.
Nit: need to be transformed
There was a problem hiding this comment.
Since this comment was pre-existing, I only capitalized the first letter and added a period at the end, but somehow I didn't notice the other grammatical issue here.
Fixed now, thanks for spotting this!
|
Looks good, but after #7407 lands this needs to be adjusted to convert the newly introduced |
|
This now needs an update to include the change from the PR mentioned above. |
…of `throw`ing This allows us to remove the `try/catch` statements used in `src/core/stream.js` when parsing JPEG images. As far as I can tell, the only reason for the current usage of plain `throw` is that `jpg.js` originally was external code. Given that this code now lives in our repo, this patch brings the JPEG code more in line with e.g. `src/core/jpx.js` and `src/core/jbig2.js`.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/35173d8fe8dff19/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/35173d8fe8dff19/output.txt Total script time: 1.22 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/026faa12c4b7b0d/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/18e9efb01923a67/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/026faa12c4b7b0d/output.txt Total script time: 23.82 mins
Image differences available at: http://107.22.172.223:8877/026faa12c4b7b0d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/18e9efb01923a67/output.txt Total script time: 39.02 mins
Image differences available at: http://107.21.233.14:8877/18e9efb01923a67/reftest-analyzer.html#web=eq.log |
|
Good to have this, thank you! |
This allows us to remove the
try/catchstatements used insrc/core/stream.jswhen parsing JPEG images.As far as I can tell, the only reason for the current usage of plain
throwis thatjpg.jsoriginally was external code. Given that this code now lives in our repo, this patch brings the JPEG code more in line with e.g.src/core/jpx.jsandsrc/core/jbig2.js.Edit: Easier reviewing with https://github.com/mozilla/pdf.js/pull/7591/files?w=1.