Fix lint warnings in URL polyfill #7626
Conversation
|
I have a doubt regarding the object which was called P.S. This is my first P.R. on any open source project ever. Please suggest changes if any. |
| if (null !== this._password) { | ||
| this._password += tempC; | ||
| } else { | ||
| this._username += tempC; |
There was a problem hiding this comment.
Remove two spaces here.
|
Thank you for your contribution! Your patch looks good and I have added a few comments to improve it. Note that I adjusted the title of the pull request to make it more descriptive. I also put "Fixes #..." in the pull request description so that GitHub closes the issue automatically once we merge this pull request. If possible, after squashing the commits, change the commit message to "Fix lint warnings in URL polyfill" (you can do this with |
|
Also it'd be great if the commit message was updated to e.g. |
yashsriv
force-pushed
the
lint-fix-url-polyfill
branch
from
97d71cf to
4e428c7
Compare
|
Updated as per the comments. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/69747ff130df57b/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/69747ff130df57b/output.txt Total script time: 1.18 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/2b222e7f2db225e/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/25184ab8769851f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/2b222e7f2db225e/output.txt Total script time: 24.72 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/25184ab8769851f/output.txt Total script time: 37.81 mins
|
|
Nice work, thank you! |
Fix lint warnings in URL polyfill
Fixes #6872.