-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve rendering of non-embedded NuptialScript font #7700
Improve rendering of non-embedded NuptialScript font #7700
Conversation
*This patch fixes something that I noticed while debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1308536.* The PDF file contains a font called "NuptialScript", which unfortunately is not embedded. Since that is a non-standard font we will not be able to render it entirely correct. However, by adding "NuptialScript" to the `getNonStdFontMap`, we can at least improve the rendering slightly by using an italic (serif) fallback font.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/037c627584ca30a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/037c627584ca30a/output.txt Total script time: 2.11 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a3040f0c67ab842/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/31ea5f85678e957/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/31ea5f85678e957/output.txt Total script time: 26.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a3040f0c67ab842/output.txt Total script time: 27.53 mins
|
Thanks for the reviews! /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/483e5338dd51bca/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/a3f27e3e91ae5fd/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/a3f27e3e91ae5fd/output.txt Total script time: 26.01 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/483e5338dd51bca/output.txt Total script time: 26.02 mins
|
…alScript Improve rendering of non-embedded NuptialScript font
This patch fixes something that I noticed while debugging https://bugzilla.mozilla.org/show_bug.cgi?id=1308536.
The PDF file contains a font called "NuptialScript", which unfortunately is not embedded. Since that is a non-standard font we will not be able to render it entirely correct. However, by adding "NuptialScript" to the
getNonStdFontMap
, we can at least improve the rendering slightly by using an italic (serif) fallback font.