Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-minor] Add basic support for Launch actions (issue 1778, issue 3897, issue 6616) #7745

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Oct 21, 2016

In general we neither want, nor can, support arbitrary Launch actions. But in practice, all the cases we've seen so far just contains relative URLs to other PDF files. Building on PR #7689, we can thus at least support basic Launch actions.

Fixes #1778.
Fixes #6616.
(Also fixes one of the points in #3897.)

… 3897, issue 6616)

In general we neither want, nor can, support arbitrary `Launch` actions. But in practice, all the cases we've seen so far just contains relative URLs to other PDF files. Building on PR 7689, we can thus at least support basic `Launch` actions.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9c9b4b94beca9d3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/9c9b4b94beca9d3/output.txt

Total script time: 2.62 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2cbbc1f303568ae/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/ceceaff738141e0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/ceceaff738141e0/output.txt

Total script time: 26.02 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/2cbbc1f303568ae/output.txt

Total script time: 38.09 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 6e22b32 into mozilla:master Nov 1, 2016
@timvandermeij
Copy link
Contributor

Thank you! I agree that this is probably the most we can do for Launch actions.

@Snuffleupagus Snuffleupagus deleted the Launch-actions branch November 1, 2016 20:18
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
[api-minor] Add basic support for `Launch` actions (issue 1778, issue 3897, issue 6616)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants