-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Add basic support for Launch
actions (issue 1778, issue 3897, issue 6616)
#7745
Conversation
… 3897, issue 6616) In general we neither want, nor can, support arbitrary `Launch` actions. But in practice, all the cases we've seen so far just contains relative URLs to other PDF files. Building on PR 7689, we can thus at least support basic `Launch` actions.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9c9b4b94beca9d3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9c9b4b94beca9d3/output.txt Total script time: 2.62 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2cbbc1f303568ae/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/ceceaff738141e0/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/ceceaff738141e0/output.txt Total script time: 26.02 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2cbbc1f303568ae/output.txt Total script time: 38.09 mins
|
Thank you! I agree that this is probably the most we can do for |
[api-minor] Add basic support for `Launch` actions (issue 1778, issue 3897, issue 6616)
In general we neither want, nor can, support arbitrary
Launch
actions. But in practice, all the cases we've seen so far just contains relative URLs to other PDF files. Building on PR #7689, we can thus at least support basicLaunch
actions.Fixes #1778.
Fixes #6616.
(Also fixes one of the points in #3897.)