-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more validation to PDFLinkService_navigateTo
#7750
Add more validation to PDFLinkService_navigateTo
#7750
Conversation
…lement_bindLink`
In some PDF files, the first element (i.e. the one containing either a `Ref` or a `Number` pointing to a page) of the explicit destination Array may be bogus. One such example is actually the file `pdf.pdf` in the test-suite, where some destinations are incompletely specified. One such example being the `G1.998360` destination whose explicit destination Array contains `[null, /XYZ, 54, 488, null]`, i.e. the destination page is `null`. Hence this patch adds a bit more validation for that case. It also adds an additional check to ensure that the resulting `pageNumber` is non-negative, and finally a couple more error messages for existing cases of malformed data.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1b098105cdb98b5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1b098105cdb98b5/output.txt Total script time: 1.91 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://107.21.233.14:8877/37bd68fdd1a6cd9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://107.22.172.223:8877/88d278f5bb923af/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/88d278f5bb923af/output.txt Total script time: 25.70 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/37bd68fdd1a6cd9/output.txt Total script time: 37.81 mins
|
Thank you for the patch! |
…igateTo-more-validation Add more validation to `PDFLinkService_navigateTo`
Please refer to the individual commit messages.
This change is