Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve lint coverage and correct code style violations #7774

Merged
merged 3 commits into from
Nov 1, 2016
Merged

Improve lint coverage and correct code style violations #7774

merged 3 commits into from
Nov 1, 2016

Conversation

timvandermeij
Copy link
Contributor

The commit messages provide more information about the changes.

@timvandermeij
Lint: update .jshintignore
c719762 
Remove folders that no longer exist and ignore folders with binary/PDF
files.
@timvandermeij
Lint: do not ignore external/importL10n as it is one of our components
978b214
@timvandermeij
Lint: correct code style violations
5194e68 
Manual observations and working with other linting tools found these.
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/8f1981c1269f683/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/8f1981c1269f683/output.txt

Total script time: 2.70 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/18263c454c58599/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/6af854c1a336909/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/6af854c1a336909/output.txt

Total script time: 25.91 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Nov 1, 2016

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/18263c454c58599/output.txt

Total script time: 38.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor Author

@Snuffleupagus Could you review this?

@Snuffleupagus Snuffleupagus merged commit 9295114 into mozilla:master Nov 1, 2016
@Snuffleupagus
Copy link
Collaborator

Looks good, thank you!

@timvandermeij timvandermeij deleted the lint branch November 1, 2016 18:41
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
@Snuffleupagus
Merge pull request mozilla#7774 from timvandermeij/lint
8424810 
Improve lint coverage and correct code style violations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Snuffleupagus Snuffleupagus

Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus