Make the customScaleOption disabled to prevent it being keyboard accessible (bug 1315608)
#7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessible (bug 1315608) Given that the `customScaleOption` should already be hidden, provided that the browser supports that, this patch also prevents it from being accessible via the keyboard. As far as my testing goes in various browsers, this doesn't seem to have any ill effects, and note that we're already explicitly ignoring the `custom` value in the `select` event handler. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1315608.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/75dcb876fbb2411/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/75dcb876fbb2411/output.txt Total script time: 2.64 mins Published |
|
Thank you! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Make the `customScaleOption` disabled to prevent it being keyboard accessible (bug 1315608)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
customScaleOptionshould already be hidden, provided that the browser supports that, this patch also prevents it from being accessible via the keyboard.As far as my testing goes in various browsers, this doesn't seem to have any ill effects, and note that we're already explicitly ignoring the
customvalue in theselectevent handler.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1315608.