Bidi: import Unicode types from the specification #7846
Conversation
|
/botio test |
timvandermeij
force-pushed
the
bidi-types
branch
from
306580a to
7eef011
Compare
|
/botio test |
| 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', | ||
| 'L', 'ON', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', | ||
| 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', | ||
| 'L', 'L', 'L', 'L', 'L', 'ON', 'L', 'L', 'L', 'L', 'L', 'L', 'L', 'L', |
There was a problem hiding this comment.
Nit: Please remove the trailing comma here, since I'd assume that otherwise you add an undefined element at the end of the Array. It probably doesn't matter too much given how this Array is used below, but it seems good to fix this nonetheless.
There was a problem hiding this comment.
Fixed in the new commit.
| 'AL', 'AL', 'AL', 'NSM', 'NSM', 'NSM', 'NSM', 'NSM', 'NSM', 'NSM', 'AN', | ||
| 'ON', 'NSM', 'NSM', 'NSM', 'NSM', 'NSM', 'NSM', 'AL', 'AL', 'NSM', 'NSM', | ||
| 'ON', 'NSM', 'NSM', 'NSM', 'NSM', 'AL', 'AL', 'EN', 'EN', 'EN', 'EN', | ||
| 'EN', 'EN', 'EN', 'EN', 'EN', 'EN', 'AL', 'AL', 'AL', 'AL', 'AL', 'AL', |
There was a problem hiding this comment.
Nit: Please remove the trailing comma here, since I'd assume that otherwise you add an undefined element at the end of the Array. It probably doesn't matter too much given how this Array is used below, but it seems good to fix this nonetheless.
There was a problem hiding this comment.
Fixed in the new commit.
Mention the specification in the comments for future reference. These types have been imported from the CSV source.
timvandermeij
force-pushed
the
bidi-types
branch
from
7eef011 to
1ce8ca8
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e42404ec543433a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e42404ec543433a/output.txt Total script time: 2.22 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b6c25a6bb8fbc04/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e62c12150666bc1/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e62c12150666bc1/output.txt Total script time: 25.91 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b6c25a6bb8fbc04/output.txt Total script time: 27.76 mins
|
For Arabic characters, the Unicode character codes are mapped to Unicode character types using the character codes for indexing. However, the character code 0x061D is undefined (and therefore invalid) in the Unicode standard. The imported list does not contain this entry, but not having it in the list breaks indexing for items after it. Therefore, put an empty string on its position to make indexing work properly and issue a warning in the unlikely event that we encounter this character.
timvandermeij
force-pushed
the
bidi-types
branch
from
1ce8ca8 to
995be19
Compare
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/2e099b5f4eefb93/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b0a5782dffd60b5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/2e099b5f4eefb93/output.txt Total script time: 26.04 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b0a5782dffd60b5/output.txt Total script time: 27.58 mins
|
Bidi: import Unicode types from the specification
Mention the specification in the comments for future reference. These types have been imported from the CSV source.
This is a complete solution for #7844 as this makes our mapping compliant with the specification. I could not find a test case (existing or new) that shows a difference in the text content, unfortunately.