Remove a misplaced false from a condition in fixMetadata, in metadata.js, since it currently short circuits the entire condition
#7881
Conversation
…adata.js`, since it currently short circuits the entire condition This looks to me like a simple oversight, which has existed ever since PR 1598 all the way back in 2012.
|
/botio unittest |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e85c681c089ab6f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/14a01da2bc45f27/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e85c681c089ab6f/output.txt Total script time: 1.90 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/14a01da2bc45f27/output.txt Total script time: 2.67 mins
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c9356eebd330b85/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c9356eebd330b85/output.txt Total script time: 2.16 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b22d1629abc2901/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/cafe6b7542fe9d7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b22d1629abc2901/output.txt Total script time: 26.31 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/cafe6b7542fe9d7/output.txt Total script time: 27.23 mins
|
|
Good find! |
Well I didn't actually find this myself, it was found by the ESLint rule http://eslint.org/docs/rules/no-constant-condition. (I've, again, started looking into replacing JSHint with ESLint, since it's got a lot of benefits IMHO.) |
|
Awesome! I really like the idea of using ESLint as it seems to have a lot more options and is more actively maintained/used. If you find more code (style) issues, feel free to assign me for review. |
…nt-condition Remove a misplaced `false` from a condition in `fixMetadata`, in `metadata.js`, since it currently short circuits the entire condition
This looks to me like a simple oversight, which has existed ever since PR #1598 all the way back in 2012.