Enable the no-empty-pattern/no-floating-decimal/no-self-compare/no-delete-var/no-new-object ESLint rules
#7988
Conversation
…/`no-delete-var`/`no-new-object` ESLint rules The following rules required no code changes: http://eslint.org/docs/rules/no-empty-pattern http://eslint.org/docs/rules/no-floating-decimal http://eslint.org/docs/rules/no-delete-var http://eslint.org/docs/rules/no-new-object There was just one change needed in order to enable: http://eslint.org/docs/rules/no-self-compare; which I think helps readability a lot, since that comparison makes no sense until you realize that we push `NaN` onto the `stack` in some cases *and* furthermore that `NaN !== NaN`.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/74abbccbf30c4fd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4fdeb8b226336d9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4fdeb8b226336d9/output.txt Total script time: 25.79 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/74abbccbf30c4fd/output.txt Total script time: 26.88 mins
|
|
Thank you for the patch |
|
Question: where does |
It's a function that's built-in to all browsers, so no need to import anything; also see e.g. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN. |
|
You're right. I was confused because we also have |
Enable the `no-empty-pattern`/`no-floating-decimal`/`no-self-compare`/`no-delete-var`/`no-new-object` ESLint rules
The following rules required no code changes:
http://eslint.org/docs/rules/no-empty-pattern
http://eslint.org/docs/rules/no-floating-decimal
http://eslint.org/docs/rules/no-delete-var
http://eslint.org/docs/rules/no-new-object
There was just one change needed in order to enable:
http://eslint.org/docs/rules/no-self-compare; which I think helps readability a lot, since that comparison makes no sense until you realize that we push
NaNonto thestackin some cases and furthermore thatNaN !== NaN.