[Firefox addon] Stop bundling src/core/network.js into the FIREFOX/MOZCENTRAL builds (PR 7322 follow-up)
#7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`/`MOZCENTRAL` builds (PR 7322 follow-up) PR 7322 added the `PdfJsNetwork.jsm` file, instead of the general `src/core/network.js` file for the Firefox addon. However, `make.js` wasn't updated to actually stop including the now obsolete network file.
Snuffleupagus
changed the title
src/core/network.js into the FIREFOX/MOXCENTRAL builds (PR 7322 follow-up)src/core/network.js into the FIREFOX/MOZCENTRAL builds (PR 7322 follow-up)
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/042d27bdda2c89a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/042d27bdda2c89a/output.txt Total script time: 2.25 mins Published |
yurydelendik
approved these changes
Jan 24, 2017
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…rk.js [Firefox addon] Stop bundling `src/core/network.js` into the `FIREFOX`/`MOZCENTRAL` builds (PR 7322 follow-up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #7322 added the
PdfJsNetwork.jsmfile, instead of the generalsrc/core/network.jsfile for the Firefox addon. However,make.jswasn't updated to actually stop including the now obsolete network file.