Interactive forms: set the buttonValue for radio buttons that do not have a fieldValue
#8041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/e83366fa3a32027/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/e83366fa3a32027/output.txt Total script time: 2.11 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/be70593448bc7f4/output.txt |
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/26e9470affa0be1/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/be70593448bc7f4/output.txt Total script time: 22.09 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/26e9470affa0be1/output.txt Total script time: 26.94 mins
|
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Interactive forms: set the `buttonValue` for radio buttons that do not have a `fieldValue`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we skipped setting the
buttonValueif thefieldValueis not available, due to an early return. Obviously the button still has a value even if the field doesn't, so I'm not sure how I missed that before, but this patch fixes it and adds a unit test for it (that fails when this patch is not applied and passes if it is applied).Supersedes #8031.