Replacing custom bundling with webpack 2 #8046
Conversation
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5aa9ad70930b6a4/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5aa9ad70930b6a4/output.txt Total script time: 6.42 mins Published |
There was a problem hiding this comment.
I've not reviewed all the builder changes in minute detail, however everything looks OK as far as I can tell!
Besides testing this locally, I've also built the Firefox addon with this patch and used it during the day without encountering any issues, so everything appears to work as it should!
I've got one small question though: In the webpackBootstrap blocks added at the top of the built files there's a lot of tabs used, is there some configuration parameter we can utilize to have spaces instead?
r=me, with passing tests.
Really nice effort here, thank you for doing this!
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/bc1ef7eae0847bb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/a81b778949e5c1f/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/a81b778949e5c1f/output.txt Total script time: 22.69 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/bc1ef7eae0847bb/output.txt Total script time: 25.79 mins
|
|
This seems to have broken the pdf.combined.js build: https://github.com/mozilla/pdfjs-dist/commits/master/build/pdf.combined.js. console error: |
Replacing custom bundling with webpack 2
No description provided.