Fixes pdf.combined.js for webpack #8058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
force-pushed
the
fix-webpack-combined
branch
from
cb6c507 to
76479cd
Compare
Snuffleupagus
approved these changes
Feb 10, 2017
src/display/api.js
Outdated
| @@ -12,7 +12,7 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| /* globals requirejs, pdfjsLibs, __webpack_require__, __pdfjsdev_webpack__ */ | |||
| /* globals requirejs, __webpack_require__, __pdfjsdev_webpack__ */ | |||
There was a problem hiding this comment.
Nit: __webpack_require__ looks unused, can we remove that one as well?
yurydelendik
force-pushed
the
fix-webpack-combined
branch
from
76479cd to
7d9941d
Compare
|
Thanks for taking a look at this so quickly - much appreciated. Does the pdfjs-dist build automatically following a successful merge? |
yes |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Fixes pdf.combined.js for webpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8057