-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Font ascent descent calculation fix #8060
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4543a2d7eb84d9c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e7e69a49688b825/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e7e69a49688b825/output.txt Total script time: 21.90 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/4543a2d7eb84d9c/output.txt Total script time: 25.50 mins
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6f4b4215675cb3d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/11d0dbfbeb5b154/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/11d0dbfbeb5b154/output.txt Total script time: 20.90 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6f4b4215675cb3d/output.txt Total script time: 25.30 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch!
Font ascent descent calculation fix
As per PDF 1.7 Spec, page 161, section 3.8.4, corners can be any two diagonally opposite corners. Accounting for this to calculate font ascent and descent correctly.
Link:
http://www.adobe.com/content/dam/Adobe/en/devnet/acrobat/pdfs/pdf_reference_1-7.pdf
Text from the specification:
Note: Although rectangles are conventionally specified by their lower-left and upper-right corners, it is acceptable to specify any two diagonally opposite corners. Appli-cations that process PDF should be prepared to normalize such rectangles in situa-tions where specific corners are required.