-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consume the current character when encountering illegal characters in Lexer.getObject
, in order to prevent infinite loops during reading of streams (issue 8061)
#8063
Conversation
… `Lexer.getObject`, in order to prevent infinite loops during reading of streams (issue 8061) *Please note:* The rendering of the PDF file in issue 8061 first regressed in PR 7039, and then PR 7493 exacerbated the problem even further by causing an infinite loop. In this particular case, when errors were encountered inside of the `Lexer.getObject` method *itself*, we didn't advance the stream position. This thus caused an inifinite loop in `parseCMap`, since the exact same character was then parsed over and over again. Fixes 8061.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/15c3d40bb84dc1a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/15c3d40bb84dc1a/output.txt Total script time: 2.18 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9c65b522e9f50f5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/f4809b9e642d309/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f4809b9e642d309/output.txt Total script time: 21.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9c65b522e9f50f5/output.txt Total script time: 25.67 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the patch
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/5a7ecc75fbf04ac/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://54.215.176.217:8877/f77f6c94139b523/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5a7ecc75fbf04ac/output.txt Total script time: 25.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f77f6c94139b523/output.txt Total script time: 20.84 mins
|
Consume the current character when encountering illegal characters in `Lexer.getObject`, in order to prevent infinite loops during reading of streams (issue 8061)
Please note: The rendering of the PDF file in issue #8061 first regressed in PR #7039, and then PR #7493 exacerbated the problem even further by causing an infinite loop.
In this particular case, when errors were encountered inside of the
Lexer.getObject
method itself, we didn't advance the stream position. This thus caused an inifinite loop inparseCMap
, since the exact same character was then parsed over and over again.Fixes #8061.