Include the pdfjschildbootstrap.js file in the output for gulp mozcentral builds (PR 8023 follow-up)
#8067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…central` builds (PR 8023 follow-up) *Yet another thing that I unfortunately missed during review of PR 8023.* Note that previously, in `make.js` this file was being preprocessed, however as far as I can tell that wasn't actually necessary. Hence this patch just copies the file to the proper output directory. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1338395#c8.
yurydelendik
approved these changes
Feb 13, 2017
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…fjschildbootstrap.js Include the `pdfjschildbootstrap.js` file in the output for `gulp mozcentral` builds (PR 8023 follow-up)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another thing that I unfortunately missed during review of PR #8023.
Note that previously, in
make.jsthis file was being preprocessed, however as far as I can tell that wasn't actually necessary. Hence this patch just copies the file to the proper output directory.Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1338395#c8.
/cc @rvandermeulen