Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New node.js check to protect from webpack. #8070

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

yurydelendik
Copy link
Contributor

Fixes #8068

@yurydelendik yurydelendik changed the title New node.js check to protect for webpack. New node.js check to protect from webpack. Feb 14, 2017
@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e042ac07fd4ac1f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/2917db8bdf4bacf/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/2917db8bdf4bacf/output.txt

Total script time: 21.35 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/e042ac07fd4ac1f/output.txt

Total script time: 26.32 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to be fixed locally, by using the examples in https://github.com/mozilla/pdf.js/tree/master/examples/node. Thanks for the patch!

@Snuffleupagus Snuffleupagus merged commit fde609e into mozilla:master Feb 15, 2017
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
New node.js check to protect from webpack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants