Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive forms: values for checkboxes #8079

Closed

Conversation

evan-mitchell
Copy link

@evan-mitchell evan-mitchell commented Feb 17, 2017

When coming across a recently resolved issue (#6995) of radio buttons not having buttonValues, it helped solve an issue for a project that I am currently working on when it was coming to setting the value attribute on radio inputs.
However, I noticed that buttonValue was still not getting set for checkbox button widgets as well. I am proposing the following fix so that we can properly set value attributes on generated checkbox inputs from Acroform annotations.
Please let me know if I am missing something or if this is actually not an issue.

…on checkbox widgets as well as radio button widgets.
…x is true.

- removed ' character from comment to avoid max length linting error
@timvandermeij
Copy link
Contributor

timvandermeij commented Feb 18, 2017

I have looked into this and this situation does not appear to be possible. Radio buttons are linked, i.e., if one is in the "on" state, the other is/others are in the "off" state. There is a parent object that coordinates which radio button in a set is in the "on" state. Since there is no such link between check boxes as they're singular items (i.e., they hold the V entry themselves instead of a parent object), according to what I read in the PDF specification, this scenario should not happen.

I'm closing this PR because of the above. However, if a PDF file is provided that proves me wrong, I'd be happy to reopen this.

@luckygyaan
Copy link

Hi,

I am using PDF JS to integrate Acroforms in our web application and the checkbox values is not rendering. I have downloaded the latest package from git hub. Please assist me with the integration.

@evan-mitchell
Copy link
Author

@luckygyaan I had to fork a copy of pdf.js and make the following changes in annotation.js to get this working:
https://github.com/mozilla/pdf.js/pull/8079/files

Best of luck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants