Gulp: migrate baseline target from make.js
#8091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurydelendik
approved these changes
Feb 21, 2017
|
Thank you for the review! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Gulp: migrate `baseline` target from `make.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #7062 (which belongs to the ES6 modules project).
Testing steps:
gulp baselineand verify that an error is thrown since theBASELINEvariable is missing.BASELINE=bc3bceb gulp baselineand verify that the success message is shown and that thebuild/baslinedirectory is a Git repository at commitbc3bceb.BASELINE=bc3bceb gulp baselineagain and verify that it finishes sooner because it only does a fetch (printinitializeCommandwhen in doubt).BASELINE=foobar gulp baselineand verify that an error is thrown sincefoobaris not a valid commit hash.BASELINE=bc3bceb node make mozcentralbaseline mozcentraldiffand verify that a diff is created (issue Unable to create mozcentraldiff #7743).