-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Dict
s found in Object Streams are assigned an objId
in XRef.fetch
#8106
Conversation
…n `XRef.fetch` This fixes something that I noticed while working with the code in `Catalog.getPageDict` when debugging issue 8088. Note that while I don't have an example where this patch really matters, given that e.g. `PartialEvaluator.hasBlendModes` depends on the `objId` to avoid cyclic references this patch could potentially help for some PDF files.
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/f51796e8eaf83f5/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/f51796e8eaf83f5/output.txt Total script time: 2.15 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9472ede13bdfaf3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9472ede13bdfaf3/output.txt Total script time: 25.59 mins
|
The Windows tests need to be run when the Windows bot is up again. |
/botio-windows tests |
From: Bot.io (Windows)InvalidCommand not implemented: |
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6fd61d3424b481a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6fd61d3424b481a/output.txt Total script time: 22.18 mins
|
Looks good. Thank you! |
Ensure that `Dict`s found in Object Streams are assigned an `objId` in `XRef.fetch`
This fixes something that I noticed while working with the code in
Catalog.getPageDict
when debugging issue #8088.Note that while I don't have an example where this patch really matters, given that e.g.
PartialEvaluator.hasBlendModes
depends on theobjId
to avoid cyclic references this patch could potentially help for some PDF files.