Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Dicts found in Object Streams are assigned an objId in XRef.fetch #8106

Merged
merged 1 commit into from
Feb 27, 2017
Merged

Ensure that Dicts found in Object Streams are assigned an objId in XRef.fetch #8106

merged 1 commit into from
Feb 27, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Feb 24, 2017

This fixes something that I noticed while working with the code in Catalog.getPageDict when debugging issue #8088.

Note that while I don't have an example where this patch really matters, given that e.g. PartialEvaluator.hasBlendModes depends on the objId to avoid cyclic references this patch could potentially help for some PDF files.

…n `XRef.fetch`

This fixes something that I noticed while working with the code in `Catalog.getPageDict` when debugging issue 8088.

Note that while I don't have an example where this patch really matters, given that e.g. `PartialEvaluator.hasBlendModes` depends on the `objId` to avoid cyclic references this patch could potentially help for some PDF files.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/f51796e8eaf83f5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/f51796e8eaf83f5/output.txt

Total script time: 2.15 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9472ede13bdfaf3/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/9472ede13bdfaf3/output.txt

Total script time: 25.59 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

The Windows tests need to be run when the Windows bot is up again.

@brendandahl
Copy link
Contributor

/botio-windows tests

@pdfjsbot
Copy link

From: Bot.io (Windows)


Invalid

Command not implemented: tests.

@brendandahl
Copy link
Contributor

/botio-windows test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6fd61d3424b481a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/6fd61d3424b481a/output.txt

Total script time: 22.18 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij timvandermeij merged commit 1da7123 into mozilla:master Feb 27, 2017
@timvandermeij
Copy link
Contributor

Looks good. Thank you!

@Snuffleupagus Snuffleupagus deleted the ObjStm-Dict-objId branch February 27, 2017 21:09
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Ensure that `Dict`s found in Object Streams are assigned an `objId` in `XRef.fetch`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants