Add gulp task to generate refs. #8109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulpfile.js
Outdated
| gulp.task('botmakeref', function (done) { | ||
| console.log(); | ||
| console.log('### Creating reference images'); | ||
| gulp.task('makeref', makeRef); |
There was a problem hiding this comment.
nit: can you for symmetry wrap this call into the function. (and I don't know how gulp detects if the done param presents.)
There was a problem hiding this comment.
Heh, this is actually how I had it before. As for gulp, I assume it uses Function.length to see how many arguments it takes.
yurydelendik
approved these changes
Feb 24, 2017
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Add gulp task to generate refs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Far too many times I've had to go look at the command in https://github.com/mozilla/pdf.js/wiki/Contributing