-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that we don't ignore 0
values in Page.getInheritedPageProp
(issue 8125)
#8126
Conversation
… (issue 8125) It appears that I accidentally broke this in PR 6065, sorry about that! The issue in this particular PDF file is that there's `/Rotate` entries on different levels of the `/Pages` tree. We're supposed to use the `/Rotate` entry in the `/Page` dict (which is `0`), but because of an incorrect condition we instead ended up with the one from the `/Pages` dict (which is `180`). Fixes 8125.
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/74d20b4410ed47a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bc89b9a26e4a544/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/bc89b9a26e4a544/output.txt Total script time: 22.61 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/74d20b4410ed47a/output.txt Total script time: 28.31 mins
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/982843fc463739e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.215.176.217:8877/267f469d44072fd/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/267f469d44072fd/output.txt Total script time: 21.58 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/982843fc463739e/output.txt Total script time: 28.42 mins
|
Ensure that we don't ignore `0` values in `Page.getInheritedPageProp` (issue 8125)
It appears that I accidentally broke this in PR #6065, sorry about that!
The issue in this particular PDF file is that there's
/Rotate
entries on different levels of the/Pages
tree. We're supposed to use the/Rotate
entry in the/Page
dict (which is0
), but because of an incorrect condition we instead ended up with the one from the/Pages
dict (which is180
).Fixes #8125.