Return undefined instead of Dict.empty from Page.getInheritedPageProp for non-existent properties to prevent possible future bugs
#8129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eProp` for non-existent properties to prevent possible future bugs *This is something that I noticed while working on PR 8126, which is (more) fallout from PR 6065.* In general, it's actually *not* correct to return `Dict.empty` as the default value for non-existent properties. Please note that a prior PR, see #5957 (comment), asked for that behaviour but I don't think that's right. Obviously for properties that are (or should) be `Dict`s it makes sense, however certain properties can be e.g. Strings or Arrays instead. In the latter case, returning `Dict.empty` is just plain wrong, and it's quite fascinating that this hasn't caused any errors in practice. (The existing validation in the various getters has actually saved us here.) Also, when looking at this code again, it seemed unnecessary to duplicate the `MAX_LOOP_COUNT` check since we could just return immediately instead.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/223ef3835fe8c42/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/8db480e3655da0a/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/8db480e3655da0a/output.txt Total script time: 22.31 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/223ef3835fe8c42/output.txt Total script time: 28.49 mins
|
timvandermeij
approved these changes
Mar 4, 2017
|
Looks good. Thank you for the fix! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…op-undefined Return `undefined` instead of `Dict.empty` from `Page.getInheritedPageProp` for non-existent properties to prevent possible future bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something that I noticed while working on PR #8126, which is (more) fallout from PR #6065.
In general, it's actually not correct to return
Dict.emptyas the default value for non-existent properties. Please note that a prior PR, see #5957 (comment), asked for that behaviour but I don't think that's right.Obviously for properties that are (or should) be
Dicts it makes sense, however certain properties can be e.g. Strings or Arrays instead. In the latter case, returningDict.emptyis just plain wrong, and it's quite fascinating that this hasn't caused any errors in practice. (The existing validation in the various getters has actually saved us here.)Also, when looking at this code again, it seemed unnecessary to duplicate the
MAX_LOOP_COUNTcheck since we could just return immediately instead.