Get rid of element.removeChild(element.firstChild) usage (bug 1345253)
#8138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just upstreaming the changes from [bug 1345253](https://bugzilla.mozilla.org/show_bug.cgi?id=1345253) as-is, it seemed better to simply get rid of the loops altogether and use the same approach as in `PDFViewer`/`PDFThumbnailViewer`.
…setting `PDFOutlineViewer`, to prevent incorrect alignment if a new document is opened
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/fed714fdc0e2ece/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/fed714fdc0e2ece/output.txt Total script time: 2.23 mins Published |
timvandermeij
approved these changes
Mar 8, 2017
|
Thank you! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Get rid of `element.removeChild(element.firstChild)` usage (bug 1345253)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just upstreaming the changes from bug 1345253 as-is, it seemed better to simply get rid of the loops altogether and use the same approach as in
PDFViewer/PDFThumbnailViewer.The PR also fixes an existing issue with
PDFOutlineViewer.resetnot actually resetting all the state it should.Fixes #8139.