Add (and adjust) a couple of findbar title attributes, in viewer.html, that doesn't agree with the l10n/en-US/viewer.properties file
#8156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tml`, that doesn't agree with the `l10n/en-US/viewer.properties` file The point of this patch is to fix a couple of inconsistencies in `viewer.html`, compared to the locale files, such that the viewer would work correctly even without the `l10n/` files present. *Note:* Since this isn't changing any of the locale files, we should *not* need to update any of the string names. Looking through the history of the findbar code, it seems that the `findPrevious`/`findNext` buttons have never had a `title` set (note PR 2168, which was the initial findbar implementation). Furthermore, the `placeholder` of the `findInput` didn't agree 100% with locale file either, so this is also adjusted.
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c14190d50e419c2/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/c14190d50e419c2/output.txt Total script time: 2.14 mins Published |
timvandermeij
approved these changes
Mar 12, 2017
|
Thank you for improving this! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…tles Add (and adjust) a couple of findbar `title` attributes, in `viewer.html`, that doesn't agree with the `l10n/en-US/viewer.properties` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The point of this patch is to fix a couple of inconsistencies in
viewer.html, compared to the locale files, such that the viewer would work correctly even without thel10n/files present.Note: Since this isn't changing any of the locale files, we should not need to update any of the string names.
Looking through the history of the findbar code, it seems that the
findPrevious/findNextbuttons have never had atitleset (note PR #2168, which was the initial findbar implementation).Furthermore, the
placeholderof thefindInputdidn't agree 100% with locale file either, so this is also adjusted.