Improve the error handling when loading of built-in CMap files fail (PR 8064 follow-up) #8205
Conversation
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/518b6399e960779/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/518b6399e960779/output.txt Total script time: 60.00 mins |
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9b7114a00efc37b/output.txt |
…PR 8064 follow-up) I happened to notice that the error handling wasn't that great, which I missed previously since there were no unit-tests for failure to load built-in CMap files. Hence this patch, which improves the error handling *and* adds tests.
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/9b7114a00efc37b/output.txt Total script time: 60.00 mins |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/2f1784eb9f3540c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ef41b93177715c9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/ef41b93177715c9/output.txt Total script time: 23.65 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/2f1784eb9f3540c/output.txt Total script time: 30.60 mins
|
|
It appears that the Linux bot is using a really old version of Chrome (version 46), as evident from the logs: For now, I simply removed the ES6 features included in the first version of the patch, and now all tests pass as they should. |
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a7ddbac41fc82b7/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a7ddbac41fc82b7/output.txt Total script time: 2.76 mins Published |
|
Looks good. Thank you! |
Improve the error handling when loading of built-in CMap files fail (PR 8064 follow-up)
I happened to notice that the error handling wasn't that great, which I missed previously since there were no unit-tests for failure to load built-in CMap files.
Hence this patch, which improves the error handling and adds tests.
Marginally easier reviewing with https://github.com/mozilla/pdf.js/pull/8205/files?w=1