-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ios: Patch cancelAnimationFrame whenever fakeRequestAnimationFrame is used #8222
ios: Patch cancelAnimationFrame whenever fakeRequestAnimationFrame is used #8222
Conversation
… used The existing implementation of fakeRequestAnimationFrame did not return a timer ID, so the frame could not be cancelled if you wanted to cancel it. But if you do want to cancel it, it needs to be cancelled through clearTimeout instead of cancelAnimationFrame, because the timer IDs are different. Signed-off-by: Jonathan Barnes <[email protected]>
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://54.215.176.217:8877/6658f26013393a5/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/aca0daee0aeccaa/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6658f26013393a5/output.txt Total script time: 23.25 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/aca0daee0aeccaa/output.txt Total script time: 29.21 mins
|
Thank you for the patch. |
…ation-frame ios: Patch cancelAnimationFrame whenever fakeRequestAnimationFrame is used
The existing implementation of fakeRequestAnimationFrame
did not return a timer ID, so the frame could not be cancelled
if you wanted to cancel it. But if you do want to cancel it,
it needs to be cancelled through clearTimeout instead of
cancelAnimationFrame, because the timer IDs are different.
ex, without the patch this wouldn't work in iOS: