Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily load NetUtil.jsm in PdfStreamConverter.jsm. #8232

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

amccreight
Copy link
Contributor

This is one step towards not loading NetUtil.jsm at startup in a clean profile.

I ran gulp lint, and tested that Firefox passes the pdf.js tests locally when this is applied.

This is one step towards not loading NetUtil.jsm at startup in a clean
profile.
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Apr 3, 2017

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c542b14d10a5cd0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Apr 3, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/c542b14d10a5cd0/output.txt

Total script time: 2.74 mins

Published

@yurydelendik yurydelendik self-requested a review April 3, 2017 19:23
Copy link
Contributor

@yurydelendik yurydelendik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yurydelendik yurydelendik merged commit 12c1679 into mozilla:master Apr 3, 2017
@yurydelendik
Copy link
Contributor

https://bugzilla.mozilla.org/show_bug.cgi?id=1353089

Thank you for the patch.

@amccreight amccreight deleted the lazy-net-util branch April 3, 2017 22:45
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Lazily load NetUtil.jsm in PdfStreamConverter.jsm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants