-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out Firefox addon Telemetry wrapper #8239
Conversation
We are planning to remove the addon histogram APIs from Firefox Telemetry. The easy solution here is to just stub out all calls that use them.
@yurydelendik for review? |
With these changes, I think that you can also remove the following lines since they shouldn't be neecessary: https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/content/PdfJsTelemetry-addon.jsm#L15-L16.
Unfortunately, running e.g. |
Thank you for the patch. |
Is there a reason why we cannot just remove the file altogether? I don't really see why we need to keep this around if it does nothing anymore, especially since the add-on is primarily used for development purposes. I don't think we need to be backwards compatible here, unless I'm missing something... |
We use it at PdfStreamConverter.jsm, we can further rename it to have a "-stub", similar to pdfjs-stub.jsm |
Thank you. In that case we probably need to keep it around for compatibility. Renaming it to have a |
Stub out Firefox addon Telemetry wrapper
We are planning to remove the addon histogram APIs from Firefox
Telemetry in bug 1353295.
pdf.js is one of 3 projects that ever used them.
The easy solution here seems to just stub out all calls that use addon histograms, that should keep things working just as before.
linting passes fine locally.
I had trouble getting the tests to run due to
grunt makeref
running into md5 mismatches.