-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves Uint32ArrayView and hasCanvasTypedArrays into compatibility.js. #8283
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/8c2cee2807e5338/output.txt |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ce48aff808a3e31/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://54.215.176.217:8877/17eff562353036d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/8c2cee2807e5338/output.txt Total script time: 6.84 mins Published |
10e24a3
to
83adf96
Compare
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/17eff562353036d/output.txt Total script time: 23.45 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/ce48aff808a3e31/output.txt Total script time: 30.82 mins
Image differences available at: http://107.21.233.14:8877/ce48aff808a3e31/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b8b4730f9deb282/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/3937700923019c7/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/3937700923019c7/output.txt Total script time: 23.21 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/b8b4730f9deb282/output.txt Total script time: 30.78 mins
Image differences available at: http://107.21.233.14:8877/b8b4730f9deb282/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking this up and finishing it!
r=me, with this code removed as well: https://github.com/mozilla/pdf.js/blob/master/src/display/global.js#L299-L305.
83adf96
to
30bee9f
Compare
we cannot fully remove these line from API versioning point of view -- replacing it with const value. |
Moves Uint32ArrayView and hasCanvasTypedArrays into compatibility.js.
Following up on #8155 (comment) comment: