Allow to convert (some of) ES6 code to ES5. #8287
Conversation
gulpfile.js
Outdated
| options: { | ||
| presets: ['es2015'], |
There was a problem hiding this comment.
Unless I'm completely mistaken, this will cause all build targets to output ES5 compatible code. For e.g. GENERIC builds that makes sense, but for e.g. FIREFOX or MOZCENTRAL I think it'd be nice if we would be able to keep the code as ES6.
Could we perhaps utilize the PDFJS_NEXT build flag, and only add this es2015 preset when PDFJS_NEXT === false?
There was a problem hiding this comment.
Agree, is there a preset for somewhat stable stuff implemented by Firefox and Chrome? We can raise this as an issue later.
There was a problem hiding this comment.
Agree, is there a preset for somewhat stable stuff implemented by Firefox and Chrome?
I don't know if there's a preset, but based on http://kangax.github.io/compat-table/es6/ it seems that the stable versions of both Firefox and Chrome already support most (if not all) of the ES6 features.
So, I cannot imagine that we'd run into too much trouble if we simply add a PDFJS_NEXT check in this patch.
yurydelendik
force-pushed
the
babel-es2015-preset
branch
from
085efdd to
5855c0a
Compare
Allow to convert (some of) ES6 code to ES5.
Currently webpack and lib publishing does not convert ES6 code to the legacy ECMAScript. This will fix it.
glyphlist and unicode are too complex for babel -- ignoring them for now. We can keep them as commonjs modules