Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the document properties to ES6 syntax #8296

Merged
merged 1 commit into from
Apr 16, 2017

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Apr 16, 2017

Moreover, add a missing option to the JSDoc comment and reorder the assignments in the constructor to match the order in the JSDoc comment.

Easier reviewing with https://github.com/mozilla/pdf.js/pull/8296/files?w=1.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/967d338fb4c3d69/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/967d338fb4c3d69/output.txt

Total script time: 3.17 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@Snuffleupagus Snuffleupagus merged commit 009d91d into mozilla:master Apr 16, 2017
@timvandermeij timvandermeij deleted the es6-document-properties branch April 16, 2017 21:19
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…rties

Convert the document properties to ES6 syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants