Convert the sidebar to ES6 syntax #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
force-pushed
the
es6-sidebar
branch
from
fceba72 to
05fc1d7
Compare
|
/botio-linux preview |
Snuffleupagus
approved these changes
Apr 23, 2017
web/pdf_sidebar.js
Outdated
| * the viewers (PDFViewer/PDFThumbnailViewer) are updated correctly. | ||
| */ | ||
| // Callback used when the sidebar has been opened/closed, to ensure that | ||
| // the viewers (PDFViewer/PDFThumbnailViewer) are updated correctly. |
There was a problem hiding this comment.
Nit: I followed the same pattern as in PDFDocumentLoadingTask when adding this comment, so unless you object strongly my preference would be to keep the formatting intact here :-)
There was a problem hiding this comment.
Done in the new commit.
timvandermeij
force-pushed
the
es6-sidebar
branch
from
05fc1d7 to
26ad82f
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/195f34d8af0d354/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/195f34d8af0d354/output.txt Total script time: 3.07 mins Published |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Convert the sidebar to ES6 syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier reviewing with https://github.com/mozilla/pdf.js/pull/8306/files?w=1.