[Firefox addon] Upstream changes from: Bug 1356569 - Remove optional trailing parameters (issue 8310) #8311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trailing parameters (issue 8310) In https://bugzilla.mozilla.org/show_bug.cgi?id=1355216, the *third* parameter of `Services.obs.addObserver` was made optional. However, omitting it in Firefox versions *without* that patch causes failures that completely prevents the addon from working (it won't even load). As far as I can tell, there isn't *any* way to detect ahead of time if the third parameter can be safely omitted, hence we're forced to fallback to manually checking the version number :-( *Note:* Since the `PdfJs.jsm` file is only used in the `MOZCENTRAL` build, we at least don't need to add any compatibility hacks there.
|
Looks good, thanks. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
[Firefox addon] Upstream changes from: Bug 1356569 - Remove optional trailing parameters (issue 8310)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://bugzilla.mozilla.org/show_bug.cgi?id=1355216, the third parameter of
Services.obs.addObserverwas made optional.However, omitting it in Firefox versions without that patch causes failures that completely prevents the addon from working (it won't even load).
As far as I can tell, there isn't any way to detect ahead of time if the third parameter can be safely omitted, hence we're forced to fallback to manually checking the version number :-(
Note: Since the
PdfJs.jsmfile is only used in theMOZCENTRALbuild, we at least don't need to add any compatibility hacks there.Fixes #8310.