Convert the annotation layer builder, presentation mode and rendering queue to ES6 syntax #8324
Conversation
timvandermeij
force-pushed
the
es6-annotation-presentation-rendering
branch
from
d6331cf to
8c488e8
Compare
|
/botio-linux preview |
There was a problem hiding this comment.
This looks great, thanks for doing this!
I've got one question though: Shouldn't
Lines 108 to 121 in f4690a3
web/annotation_layer_builder.js
Outdated
| /** | ||
| * @param {HTMLDivElement} pageDiv | ||
| * @param {PDFPage} pdfPage | ||
| * @param {boolean} renderInteractiveForms | ||
| * @returns {AnnotationLayerBuilder} | ||
| */ | ||
| createAnnotationLayerBuilder: function (pageDiv, pdfPage, | ||
| renderInteractiveForms) { | ||
| createAnnotationLayerBuilder(pageDiv, pdfPage, renderInteractiveForms) { |
There was a problem hiding this comment.
Nit: Should we use renderInteractiveForms = false here, just to signal what the default value is?
There was a problem hiding this comment.
Done in the new commit. I have updated the interface as well. With the new ES6 syntax, ESLint is able to detect that the interface is not used anywhere (expected due to its nature), so we have to disable linting there. Otherwise it's a trivial change.
timvandermeij
force-pushed
the
es6-annotation-presentation-rendering
branch
from
8c488e8 to
a51311b
Compare
|
/botio-linux preview |
timvandermeij
force-pushed
the
es6-annotation-presentation-rendering
branch
from
a51311b to
24d44b2
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/40ccd7092a90a6a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/40ccd7092a90a6a/output.txt Total script time: 3.90 mins Published |
…sentation-rendering Convert the annotation layer builder, presentation mode and rendering queue to ES6 syntax
Easier reviewing with https://github.com/mozilla/pdf.js/pull/8324/files?w=1.