-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable running the ui_utils
unit-tests on Travis
#8331
Enable running the ui_utils
unit-tests on Travis
#8331
Conversation
With the exception of just one test-case, all the current `ui_utils` unit-tests can run successfully on Node.js (since most of them doesn't rely on the DOM). To get this working, I had to first of all add a new `LIB` build flag such that `gulp lib` produces a `web/pdfjs.js` file that is able to load `pdf.js` successfully. Second of all, since neither `document` nor `navigator` is available in Node.js, `web/ui_utils.js` was adjusted slightly to avoid errors.
/botio unittest |
From: Bot.io (Linux)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1993d3284c33cc1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/4ee5221d1447ee1/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/1993d3284c33cc1/output.txt Total script time: 3.04 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/4ee5221d1447ee1/output.txt Total script time: 6.80 mins
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/c1eed650ba3e081/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/7fb27ae3602c7e2/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/7fb27ae3602c7e2/output.txt Total script time: 24.53 mins
Image differences available at: http://54.215.176.217:8877/7fb27ae3602c7e2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/c1eed650ba3e081/output.txt Total script time: 32.24 mins
Image differences available at: http://107.21.233.14:8877/c1eed650ba3e081/reftest-analyzer.html#web=eq.log |
The test failures above are unrelated to this patch, please see issue #8334. |
Cool, thanks! |
…s-travis Enable running the `ui_utils` unit-tests on Travis
With the exception of just one test-case, all the current
ui_utils
unit-tests can run successfully on Node.js (since most of them doesn't rely on the DOM).To get this working, I had to first of all add a new
LIB
build flag such thatgulp lib
produces aweb/pdfjs.js
file that is able to loadpdf.js
successfully.Second of all, since neither
document
nornavigator
is available in Node.js,web/ui_utils.js
was adjusted slightly to avoid errors.