Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable running the ui_utils unit-tests on Travis #8331

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Enable running the ui_utils unit-tests on Travis #8331

merged 1 commit into from
Apr 27, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

With the exception of just one test-case, all the current ui_utils unit-tests can run successfully on Node.js (since most of them doesn't rely on the DOM).

To get this working, I had to first of all add a new LIB build flag such that gulp lib produces a web/pdfjs.js file that is able to load pdf.js successfully.
Second of all, since neither document nor navigator is available in Node.js, web/ui_utils.js was adjusted slightly to avoid errors.

With the exception of just one test-case, all the current `ui_utils` unit-tests can run successfully on Node.js (since most of them doesn't rely on the DOM).

To get this working, I had to first of all add a new `LIB` build flag such that `gulp lib` produces a `web/pdfjs.js` file that is able to load `pdf.js` successfully.
Second of all, since neither `document` nor `navigator` is available in Node.js, `web/ui_utils.js` was adjusted slightly to avoid errors.
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1993d3284c33cc1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/4ee5221d1447ee1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1993d3284c33cc1/output.txt

Total script time: 3.04 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/4ee5221d1447ee1/output.txt

Total script time: 6.80 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/c1eed650ba3e081/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/7fb27ae3602c7e2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/7fb27ae3602c7e2/output.txt

Total script time: 24.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/7fb27ae3602c7e2/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/c1eed650ba3e081/output.txt

Total script time: 32.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/c1eed650ba3e081/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

The test failures above are unrelated to this patch, please see issue #8334.

@timvandermeij timvandermeij merged commit f4690a3 into mozilla:master Apr 27, 2017
@timvandermeij
Copy link
Contributor

Cool, thanks!

@Snuffleupagus Snuffleupagus deleted the ui-utils-unit-tests-travis branch April 27, 2017 14:02
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…s-travis

Enable running the `ui_utils` unit-tests on Travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants