Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subtract the X/Y offsets when decoding refinement regions of JBIG2 images (issue 7145, 7308, 7401, 7850, 8270) #8335

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Subtract the X/Y offsets when decoding refinement regions of JBIG2 images (issue 7145, 7308, 7401, 7850, 8270) #8335

merged 1 commit into from
Apr 28, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

Please refer to the JBIG2 standard, see https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-T.88-200002-I!!PDF-E&type=items.
In particular, section "6.3.5.3 Fixed templates and adaptive templates" mentions that the offsets should be subtracted; where the offsets are defined according to "Table 6" under section "6.3.2 Input parameters".

Fixes #7145.
Fixes #7308.
Fixes #7401.
Fixes #7850.
Fixes #8270.

…ages (issue 7145, 7308, 7401, 7850, 8270)

Please refer to the JBIG2 standard, see https://www.itu.int/rec/dologin_pub.asp?lang=e&id=T-REC-T.88-200002-I!!PDF-E&type=items.
In particular, section "6.3.5.3 Fixed templates and adaptive templates" mentions that the offsets should be *subtracted*; where the offsets are defined according to "Table 6" under section "6.3.2 Input parameters".

Fixes 7145.
Fixes 7308.
Fixes 7401.
Fixes 7850.
Fixes 8270.
@Snuffleupagus
Copy link
Collaborator Author

Please note that any failures in forms test-cases are not caused by this patch, please see issue #8334.

/botio test

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/d4ebead1676f2f1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/42cd0cebb7d403d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/42cd0cebb7d403d/output.txt

Total script time: 21.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/d4ebead1676f2f1/output.txt

Total script time: 34.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/054e631fe6b2879/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/afb5ba1ae7d298f/output.txt

@brendandahl
Copy link
Contributor

/botio-linux-new makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/877257ea02d5efd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/afb5ba1ae7d298f/output.txt

Total script time: 20.37 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/877257ea02d5efd/output.txt

Total script time: 33.47 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus merged commit 165294a into mozilla:master Apr 28, 2017
@Snuffleupagus
Copy link
Collaborator Author

Landing with r=yury on IRC.

@janpe2 Thank you so much for figuring this out!

@Snuffleupagus Snuffleupagus deleted the jbig2-decodeRefinement-subtract-offsets branch April 28, 2017 21:16
@pdfjsbot
Copy link

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/054e631fe6b2879/output.txt

Total script time: 60.00 mins

  • Lint: Passed

movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…ment-subtract-offsets

Subtract the X/Y offsets when decoding refinement regions of JBIG2 images (issue 7145, 7308, 7401, 7850, 8270)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants