Ignore line-breaks between operator and digit in Lexer.getNumber
#8359
Conversation
This is consistent with the behaviour in Adobe Reader (and PDFium), and it fixes the display of page 30 in https://bug1354114.bmoattachments.org/attachment.cgi?id=8855457 (taken from https://bugzilla.mozilla.org/show_bug.cgi?id=1354114). The patch also makes the `error` message for invalid numbers slightly more useful, by including the charCode as well. (Having that information available would have reduced the time spent on debugging the PDF file above.)
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/69463d4f186ed5f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/69463d4f186ed5f/output.txt Total script time: 1.56 mins Published |
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/24d98ca8f2e0e63/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5b52884f4b1cb5d/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5b52884f4b1cb5d/output.txt Total script time: 21.02 mins
|
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/24d98ca8f2e0e63/output.txt Total script time: 60.00 mins |
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ceadaa948d0132e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ceadaa948d0132e/output.txt Total script time: 19.37 mins
|
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/afeae840a96d8d6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/09ba95a8dda735c/output.txt |
|
Thank you for the patch. |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/09ba95a8dda735c/output.txt Total script time: 20.52 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/afeae840a96d8d6/output.txt Total script time: 31.85 mins
|
|
/botio-linux test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bfa6e045b7adaee/output.txt |
|
/botio-linux makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 1 Live output at: http://54.67.70.0:8877/811e74cad917642/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bfa6e045b7adaee/output.txt Total script time: 19.33 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/811e74cad917642/output.txt Total script time: 18.56 mins
|
…nore-line-breaks Ignore line-breaks between operator and digit in `Lexer.getNumber`
This is consistent with the behaviour in Adobe Reader (and PDFium), and it fixes the display of page 30 in https://bug1354114.bmoattachments.org/attachment.cgi?id=8855457 (taken from https://bugzilla.mozilla.org/show_bug.cgi?id=1354114).
The patch also makes the
errormessage for invalid numbers slightly more useful, by including the charCode as well. (Having that information available would have reduced the time spent on debugging the PDF file above.)