-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds initializeFromPort to the WorkerMessageHandler. #8363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, r=me with passing tests.
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/f712199f8d0cd7d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://54.215.176.217:8877/f215a78e057094a/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/f712199f8d0cd7d/output.txt Total script time: 33.54 mins
Image differences available at: http://107.21.233.14:8877/f712199f8d0cd7d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f215a78e057094a/output.txt Total script time: 21.07 mins
|
src/core/worker.js
Outdated
} | ||
}, | ||
initializeFromPort(port) { | ||
var handler = new MessageHandler('worker', 'main', self); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self
should be port
here and below, right? Otherwise port
is unused and you pass self
as parameter to this method below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
25d3b92
to
008aa56
Compare
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 1 Live output at: http://107.21.233.14:8877/5289cd19b00c4b2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/df871d4b092ccc5/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/df871d4b092ccc5/output.txt Total script time: 20.80 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5289cd19b00c4b2/output.txt Total script time: 32.68 mins
|
Adds initializeFromPort to the WorkerMessageHandler.
RE #8361 -- avoids MessageHandler exporting
/cc @tobytailor