Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds initializeFromPort to the WorkerMessageHandler. #8363

Merged
merged 1 commit into from
May 3, 2017

Conversation

yurydelendik
Copy link
Contributor

RE #8361 -- avoids MessageHandler exporting

/cc @tobytailor

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, r=me with passing tests.

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/f712199f8d0cd7d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://54.215.176.217:8877/f215a78e057094a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Linux)


Failed

Full output at http://107.21.233.14:8877/f712199f8d0cd7d/output.txt

Total script time: 33.54 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://107.21.233.14:8877/f712199f8d0cd7d/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/f215a78e057094a/output.txt

Total script time: 21.07 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

}
},
initializeFromPort(port) {
var handler = new MessageHandler('worker', 'main', self);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self should be port here and below, right? Otherwise port is unused and you pass self as parameter to this method below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 1

Live output at: http://107.21.233.14:8877/5289cd19b00c4b2/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/df871d4b092ccc5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/df871d4b092ccc5/output.txt

Total script time: 20.80 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/5289cd19b00c4b2/output.txt

Total script time: 32.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@yurydelendik yurydelendik merged commit 84f174b into mozilla:master May 3, 2017
@yurydelendik yurydelendik deleted the worker-fromport branch May 3, 2017 00:25
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Adds initializeFromPort to the WorkerMessageHandler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants