Replace unnecessary bind(this) statements with arrow functions in web/ files

[Snuffleupagus]

By using let, which is block-scoped, instead of var in a couple of places we're able to get rid of additional bind calls.

[yurydelendik]

/botio-windows preview

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_preview from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/cb3b4770d8aca19/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Success

Full output at http://54.215.176.217:8877/cb3b4770d8aca19/output.txt

Total script time: 19.74 mins

Published

• Viewer: http://54.215.176.217:8877/cb3b4770d8aca19/web/viewer.html
• Extension: http://54.215.176.217:8877/cb3b4770d8aca19/extensions/firefox/pdf.js.xpi

[yurydelendik]

this was just converted into "var" for translated code, do we need to move let inside for-block?

[yurydelendik]

let make it for(var i = 1; i <= pagesCount; i++) { let pageNum = i;

[Snuffleupagus]

Unless I'm missing something, this shouldn't be a problem. Note that Babel converts a loop with let into a loop over a function, thus creating the necessary closure; see e.g. this simple example.

The complete code, taken from the preview above, thus becomes:

onePageRenderedCapability.promise.then(function () {
  if (_pdfjs.PDFJS.disableAutoFetch) {
    pagesCapability.resolve();
    return;
  }
  var getPagesLeft = pagesCount;

  var _loop = function _loop(_pageNum) {
    pdfDocument.getPage(_pageNum).then(function (pdfPage) {
      var pageView = _this._pages[_pageNum - 1];
      if (!pageView.pdfPage) {
        pageView.setPdfPage(pdfPage);
      }
      _this.linkService.cachePageRef(_pageNum, pdfPage.ref);
      if (--getPagesLeft === 0) {
        pagesCapability.resolve();
      }
    });
  };

  for (var _pageNum = 1; _pageNum <= pagesCount; ++_pageNum) {
    _loop(_pageNum);
  }
});

[yurydelendik]

okay, nvm, I looked at wrong place

[yurydelendik]

Thank you for the patch.