Replace unnecessary var self = this statements with arrow functions in web/app.js
#8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in `web/app.js` Also replaces `var` with `let` in the functions/methods that are touched in the patch. Please note that this should be completely safe, for two separate reasons, since trying to access `let` in a scope where it's not defined is first of all a runtime error and second of all an ESLint error (thanks to the `no-undef` rule).
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://54.67.70.0:8877/dbad99713937ae8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/dbad99713937ae8/output.txt Total script time: 2.01 mins Published |
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Replace unnecessary `var self = this` statements with arrow functions in `web/app.js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replaces
varwithletin the functions/methods that are touched in the patch. Please note that this should be completely safe, for two separate reasons, since trying to accessletin a scope where it's not defined is first of all a runtime error and second of all an ESLint error (thanks to theno-undefrule).Edit: Slightly more manageable diff with https://github.com/mozilla/pdf.js/pull/8393/files?w=1.